Skip to content

Conversation

@saminacodes
Copy link
Member

@saminacodes saminacodes commented May 20, 2025

CORE-0000


PR-Codex overview

This PR focuses on updating references from "backend wallets" to "server wallets" across various files, enhancing clarity and consistency in the terminology used in the application.

Detailed summary

  • Changed href in apps/portal/src/app/pay/sidebar.tsx from ${paySlug}/overview to ${paySlug}.
  • Added an ArticleCardIndex for "Universal Bridge" in apps/portal/src/app/page.tsx.
  • Updated terminology from "backend wallet" to "server wallet" in apps/portal/src/app/engine/v2/get-started/page.mdx.
  • Updated link in apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/engine/dedicated/(instance)/[engineId]/overview/components/engine-overview.tsx to point to server wallets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added a new "Universal Bridge" resource card to the Learning Resources section, allowing users to bridge and onramp tokens on any chain.
  • Bug Fixes

    • Updated the "Overview" link in the Pay sidebar to point directly to the main Pay page instead of the overview subpage.
  • Documentation

    • Renamed references from "backend wallet" to "server wallet" and updated related links for improved clarity in documentation and interface text.

@saminacodes saminacodes requested review from a team as code owners May 20, 2025 04:42
@changeset-bot
Copy link

changeset-bot bot commented May 20, 2025

⚠️ No Changeset found

Latest commit: 3277cf6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 5:52pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 5:52pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
login ⬜️ Skipped (Inspect) May 20, 2025 5:52pm
thirdweb_playground ⬜️ Skipped (Inspect) May 20, 2025 5:52pm
wallet-ui ⬜️ Skipped (Inspect) May 20, 2025 5:52pm

@graphite-app
Copy link
Contributor

graphite-app bot commented May 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase. labels May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.81%. Comparing base (77938c4) to head (3277cf6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7091   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files         900      900           
  Lines       57848    57848           
  Branches     4077     4077           
=======================================
  Hits        32286    32286           
  Misses      25457    25457           
  Partials      105      105           
Flag Coverage Δ
packages 55.81% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 56.59 KB (0%) 1.2 s (0%) 189 ms (+178.22% 🔺) 1.4 s
thirdweb (cjs) 304.45 KB (0%) 6.1 s (0%) 576 ms (+10.5% 🔺) 6.7 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 56 ms (+1151.59% 🔺) 170 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 21 ms (+581.18% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 19.51 KB (0%) 391 ms (0%) 78 ms (+551.23% 🔺) 469 ms

@vercel vercel bot temporarily deployed to Preview – login May 20, 2025 05:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 20, 2025 05:01 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 20, 2025 05:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 20, 2025 05:01 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 20, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 20, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 20, 2025 13:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www May 20, 2025 13:39 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented May 20, 2025

Merge activity

CORE-0000

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on updating references from "backend wallets" to "server wallets" across various files and adding a new `ArticleCardIndex` component in the `page.tsx` file.

### Detailed summary
- In `sidebar.tsx`, updated `href` for the "Overview" link.
- Added a new `ArticleCardIndex` for "Universal Bridge" in `page.tsx`.
- Changed text from "backend wallets" to "server wallets" in `page.mdx`.
- Updated link in `engine-overview.tsx` to point to server wallet documentation.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 20, 2025 17:45 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 20, 2025 17:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 20, 2025 17:45 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 20, 2025

Walkthrough

The updates standardize terminology by replacing "backend wallet" with "server wallet" in both UI and documentation, and update related hyperlinks accordingly. Additionally, a new "Universal Bridge" article card is introduced to the learning resources section, and the sidebar navigation for the pay section is streamlined by adjusting the overview link.

Changes

File(s) Change Summary
.../engine/dedicated/(instance)/[engineId]/overview/components/engine-overview.tsx Updated link URL and label from "backend wallets" to "server wallets" in the BackendWalletsSection component.
.../engine/v2/get-started/page.mdx Documentation updated to rename "backend wallet" to "server wallet" and revised related bullet points and links.
.../portal/src/app/page.tsx Added a new "Universal Bridge" ArticleCardIndex to the learning resources section, linking to the /pay route.
.../portal/src/app/pay/sidebar.tsx Changed the "Overview" sidebar link to point to /pay instead of /pay/overview.

Poem

In the garden of code, a wallet’s new name,
"Server" it’s called, with links now the same.
A bridge hops in, with tokens to send,
The sidebar’s path finds a simpler end.
Rabbits rejoice with a digital cheer—
Hopping through updates, the future is here!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 77938c4 and 3277cf6.

📒 Files selected for processing (4)
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/engine/dedicated/(instance)/[engineId]/overview/components/engine-overview.tsx (1 hunks)
  • apps/portal/src/app/engine/v2/get-started/page.mdx (1 hunks)
  • apps/portal/src/app/page.tsx (1 hunks)
  • apps/portal/src/app/pay/sidebar.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (5)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (5)
apps/portal/src/app/engine/v2/get-started/page.mdx (2)

100-101: Approve updated bullet terminology.
The bullet points have been correctly updated to use “server wallet” terminology, aligning with the PR’s goal of replacing “backend wallets” with “server wallets.”


104-104: Approve updated server wallet link.
The call-to-action link now points to /engine/v2/configure-wallets/server-wallet with matching link text, fixing the broken reference and ensuring consistency.

apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/engine/dedicated/(instance)/[engineId]/overview/components/engine-overview.tsx (1)

98-103: Approve updated server wallet reference link.
The TrackedUnderlineLink has been updated to point at the server wallet configuration URL and text now reads “learn more about server wallets,” ensuring the component’s terminology and hyperlink are correct.

apps/portal/src/app/pay/sidebar.tsx (1)

24-24: Link update looks good

The href is now simplified from /pay/overview to just /pay, which aligns with the PR objective of fixing broken links. This change ensures the overview link in the sidebar points to the correct location.

apps/portal/src/app/page.tsx (1)

157-162: Successfully added Universal Bridge card

The new ArticleCardIndex component for "Universal Bridge" is properly integrated into the learning resources section. This addition enhances the documentation interface by providing a direct path to the bridge and onramp functionality, which aligns with the PR objectives.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot merged commit 3277cf6 into main May 20, 2025
24 checks passed
@graphite-app graphite-app bot deleted the ub-corrections branch May 20, 2025 17:52
@vercel vercel bot temporarily deployed to Production – thirdweb_playground May 20, 2025 17:52 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui May 20, 2025 17:52 Inactive
@vercel vercel bot temporarily deployed to Production – login May 20, 2025 17:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants